Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified multi-strike move flags #3126

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Unified multi-strike move flags #3126

merged 2 commits into from
Jul 18, 2023

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Unified twoStrikes and threeStrikes flags into strikeCount.

  • A value of 0 is treated as 1 hit.
  • Supports up to 255 hits (can be reduced if needed).

Images

100-hit example
mGBA_t2Ahl81kld

Discord contact info

AsparagusEduardo

@DizzyEggg
Copy link
Collaborator

DizzyEggg commented Jul 15, 2023 •
edited
Loading

Do we actually need to waste 8 bits for a possibility of a move hitting 255 times? Personally, I would change it to strikeCount:2.

@AsparagusEduardo
Copy link
Collaborator Author

Do we actually need to waste 8 bits for a possibility of a move hitting 255 times? Personally, I would change it to strikeCount:2.

True, 255 is unneeded, but I would put at least 4 because now we have precedent for Population Bomb having 10 strikes maximum.

@DizzyEggg
Copy link
Collaborator

Do we actually need to waste 8 bits for a possibility of a move hitting 255 times? Personally, I would change it to strikeCount:2.

True, 255 is unneeded, but I would put at least 4 because now we have precedent for Population Bomb having 10 strikes maximum.

Once it's changed, I think this can be merged

@AsparagusEduardo
Copy link
Collaborator Author

Ready for merge

@DizzyEggg DizzyEggg merged commit 43ad1a4 into rh-hideout:upcoming Jul 18, 2023
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/upcoming/strikeCount branch July 27, 2023 15:57
@AsparagusEduardo AsparagusEduardo mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DizzyEggg DizzyEggg DizzyEggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsparagusEduardo @DizzyEggg